Re: [PATCH 1/3] hwmon: (asus_rog_ryujin) Add per-device configuration

Sounds good, I'm very inexperienced with the kernel workflow (I didn't
even know you could e-mail patches directly from git). All of the ids
passed into this should have that data, but a sanity check for an
invalid id definitely can't hurt. I'll make a new series and open a PR
to the drivers github repo with this change sometime this week.


On Sun, Aug 9, 2026 at 4:23 PM Arimil <[email protected]> wrote:
>
> Sounds good, I'm very inexperienced with the kernel workflow (I didn't even know you could e-mail patches directly from git). All of the ids passed into this should have that data, but a sanity check for an invalid id definitely can't hurt. I'll make a new series and open a PR to the drivers github repo with this change sometime this week.
>
> On Sun, Aug 9, 2026 at 12:37 PM Guenter Roeck <[email protected]> wrote:
>>
>> On 8/6/26 17:14, [email protected] wrote:
>> > Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider:
>> >
>> > New issues:
>> > - [High] Dynamic sysfs IDs (new_id) binding will cause a NULL pointer dereference because `id->driver_data` is unchecked.
>> >
>>
>> Looking at other drivers, this seems to be real. See wacom_probe().
>> Please add that check.
>>
>> > Pre-existing issues:
>> > - [High] Missing bounds check on HID report size before accessing payload offsets in `rog_ryujin_raw_event`, leading to an out-of-bounds read and information leak.
>> > - [High] The `status_report_request_lock` fails to protect `reinit_completion()` from concurrent `complete_all()` calls in `rog_ryujin_raw_event`.
>> > - [High] The device is exposed to HID raw events before its completions and locks are initialized, risking a NULL pointer dereference and kernel crash.
>> > - [High] The driver allocates a DMA buffer using `devm_kzalloc()`, which breaks cacheline alignment and causes memory corruption on non-coherent DMA architectures.
>> > --
>> >
>>
>> No need to fix as part of this series, though of course patches would be appreciated.
>>
>> Thanks,
>> Guenter
>>