Re: [PATCH v3 1/3] hwmon: (asus_rog_ryujin) Add per-device configuration
Guenter Roeck <[email protected]>
| Newsgroups | org.kernel.vger.linux-hwmon,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/13/26 03:07, Arimil wrote: > On Thu, Aug 13, 2026 at 12:57 AM Guenter Roeck <[email protected]> wrote: >> This is introduced by this patch and thus irrelevant for the commit >> message. >> > > Do you want me to make a v4 to fix this? > No need; I'll drop it when I apply the patch. >> We are too close for me to accept this series without independent >> Tested-by: and/or Reviewed-by: feedback. I plan to apply it after >> the next commit window closes. >> >> I won't mandate that the issues reported by Sashiko are getting fixed, >> but I wuold strongly suggest for the users of this driver to have a look >> and consider fixing them. The issues look very real to me. >> > > I have already started looking into fixing them but since this is my first ever > kernel contribution I was avoiding expanding the scope of this series > unless you explicitly asked for them to be resolved. As I said, not as part of this series, and I had hoped that Aleksa would step in. Thanks, Guenter