Re: [PATCH v3] hwmon: Add fan monitoring support for HONOR FMI-XX
| Newsgroups | org.kernel.vger.linux-hwmon |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `SENSORS_HONOR_FMI` Kconfig option is missing a dependency on `ACPI`. -- --- Patch [1]: [PATCH v3] hwmon: Add fan monitoring support for HONOR FMI-XX --- commit 049ec54bdd36a31d06eb1fb6aa8b9f74bd2a4a59 Author: Nikita Dubrovskih <[email protected]> hwmon: Add fan monitoring support for HONOR FMI-XX The HONOR FMI-XX firmware exposes a serialized \GFNS ACPI method to return fan speeds. This commit adds a DMI-restricted, read-only hwmon driver to monitor these speeds, without exposing direct Embedded Controller access. > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 2bfbcc033d599..8a11a304d2fd2 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig [ ... ] > @@ -2785,6 +2785,16 @@ config SENSORS_ASUS_EC > This driver can also be built as a module. If so, the module > will be called asus_ec_sensors. > > +config SENSORS_HONOR_FMI > + tristate "HONOR FMI-XX fan monitor" > + depends on X86 [Severity: Low] Does this Kconfig entry need a dependency on ACPI? Without CONFIG_ACPI, ACPICA core functions like acpi_get_handle() are replaced with static inline stubs that return AE_NOT_CONFIGURED. This means the driver probe function will unconditionally fail with -ENODEV, and the driver effectively becomes dead code when configured this way. > + help > + If you say yes here, you get support for fan speed monitoring on > + the HONOR FMI-XX laptop through its firmware ACPI method. [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1