Re: [PATCH] hwmon: (mcp9982) Propagate one-shot polling errors
| Newsgroups | org.kernel.vger.linux-hwmon |
|---|---|
| Message-ID | <[email protected]> |
> When a device is in standby, the driver starts a one-shot conversion and
> polls the BUSY flag before reading temperature, alarm, or fault data.
> The poll result is currently ignored. Therefore, a timeout or a
> status-register read failure can be hidden by a later successful read,
> causing stale data to be returned as valid.
>
> Return the polling error before reading the requested attribute.
>
> Fixes: e2fe950f34e5 ("hwmon: add support for MCP998X")
> Cc: [email protected]
> Signed-off-by: Nikhil Gurudasani <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1