Re: [PATCH v1 3/4] drm/hyperv: Drop useless empty remove callback

Uwe Kleine-König (The Capable Hub) <[email protected]> Mon, 20 Jul 2026 15:48:35 +0200

Newsgroups	org.kernel.vger.linux-hyperv,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel
Message-ID	<al4m34a1ZG5UTroc@monoceros>

Hello,

On Thu, Jul 02, 2026 at 08:45:14AM +0200, Thomas Zimmermann wrote:
> Am 01.07.26 um 19:05 schrieb Uwe Kleine-König (The Capable Hub):
> > Having an empty remove callback is equivalent to no remove callback.
> > (The only minor difference is that with an empty remove callback
> > pm_runtime_get_sync() and pm_runtime_put_noidle() are called.)
> > 
> > Drop this useless function.
> > 
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>
> > ---
> >   drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 5 -----
> >   1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> > index e766d87b7a9d..e3f41336a831 100644
> > --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> > +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> > @@ -45,10 +45,6 @@ static int hv_drm_pci_probe(struct pci_dev *pdev,
> >   	return 0;
> >   }
> > -static void hv_drm_pci_remove(struct pci_dev *pdev)
> > -{
> 
> It would be better to call drm_dev_unplug() from here.  With a bit more
> work, the driver can have hot-unplug functionality.

I don't have the "hardware" and thus cannot test. So I won't tackle that
suggested quest.

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)