Re: [PATCH V4 8/9] mshv: Populate mmio mappings for PCI passthru
Mukesh R <[email protected]> Fri, 24 Jul 2026 14:41:05 -0700
| Newsgroups | org.kernel.vger.linux-hyperv,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
On 7/17/26 19:33, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 8 potential issue(s) to consider: > > New issues: > - [Critical] hv_map_mmio_pages extrapolates the physical base address for an entire MMIO region from a single page fault, allowing unauthorized arbitrary physical memory access. > - [High] Flawed alignment logic allows mapping unaligned addresses as 2M large pages and fails to iterate the physical frame variable. > - [High] Unconditional use of FAULT_FLAG_WRITE in mshv_chk_get_mmio_start_pfn breaks read-only MMIO mappings. Above 2 addressed in next version. Thanks, -Mukesh ... snip ...