Re: [PATCH net] net: mana: Return error code from mana_create_rxq()

Aditya Garg <[email protected]> Mon, 27 Jul 2026 16:54:41 +0530
Newsgroups org.kernel.vger.linux-hyperv,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <[email protected]>
On 23-07-2026 21:36, Jakub Kicinski wrote:
> On Fri, 17 Jul 2026 19:48:18 -0700 Aditya Garg wrote:
>> Change mana_create_rxq() to return an int and pass the created rxq back
>> to the caller through an output parameter. The caller now propagates the
>> returned error code directly instead of substituting -ENOMEM.
> 
> We generally prefer the use of ERR_PTR to output arguments in
> the kernel. Looks like it'd work here nicely.

Thanks for the review Jakub,
I'll post a v2 using ERR_PTR/PTR_ERR

Regards,
Aditya