Re: [PATCH 3/3] x86/irq, iommu/amd, PCI: Drop redundant irq_retrigger inits
[email protected] Tue, 28 Jul 2026 13:59:05 +0000
| Newsgroups | org.kernel.vger.linux-hyperv,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> With fixup_irqs() now using irq_chip_retrigger_hierarchy() and the generic > resend path (try_retrigger()) already falling back to it, installing > irq_chip_retrigger_hierarchy() as the irq_retrigger() callback on the > outermost domain chips is no longer required. The hierarchy walk reaches > the x86 vector domain's apic_retrigger_irq() for all of these stacked > domain chips. >=20 > Remove the now redundant irq_retrigger() initializations from the outermo= st > domain interrupt chips. > msi_set_affinity() is the only site that invoked the outermost chip's > irq_retrigger() directly. Convert it to irq_chip_retrigger_hierarchy() so > the x86_init_dev_msi_info() initialization can be dropped as well. >=20 > No functional change intended. >=20 > Suggested-by: Thomas Gleixner <[email protected]> > Signed-off-by: Naman Jain <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260728135117.2888= [email protected]?part=3D3