Re: [PATCH 11/12] drm/panic: Move panic display code into helper library
Thomas Zimmermann <[email protected]>
| Newsgroups | org.kernel.vger.linux-hyperv,dev.linux.lists.imx,dev.linux.lists.sashiko-reviews,dev.linux.lists.virtualization,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.freedesktop.lists.intel-xe,org.freedesktop.lists.nouveau,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-doc,org.kernel.vger.linux-renesas-soc,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
Hi Am 18.08.26 um 17:55 schrieb Randy Dunlap: > Hi, > > On 8/18/26 5:28 AM, Thomas Zimmermann wrote: >> M: Hans de Goede <[email protected]> >> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >> index 323422861e8f..cdfd72d9a9c5 100644 >> --- a/drivers/gpu/drm/Kconfig >> +++ b/drivers/gpu/drm/Kconfig >> @@ -45,6 +45,7 @@ config DRM_MIPI_DSI >> config DRM_KMS_HELPER >> tristate >> depends on DRM >> + select DRM_PANIC_HELPER if DRM_PANIC > but DRM_PANIC_HELPER depends on DRM_TTM so > DRM_KMS_HELPER should also depend on DRM_TTM. Otherwise: Oops, how did that creep in? There's no TTM dependency. This Kconfig change appears to be a copy-paste accident. Thanks for noting. Best regards Thomas > > WARNING: unmet direct dependencies detected for DRM_PANIC_HELPER > Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_TTM [=n] > Selected by [y]: > - DRM_KMS_HELPER [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_PANIC [=y] > > >> select FB_CORE if DRM_FBDEV_EMULATION >> help >> CRTC helpers for KMS drivers. >> @@ -130,6 +131,10 @@ config DRM_PANIC_SCREEN_QR_VERSION >> Smaller QR code are easier to read, but will contain less debugging >> data. Default is 40. >> >> +config DRM_PANIC_HELPER >> + bool >> + depends on DRM_TTM >> + >> config DRM_RAS >> bool "DRM RAS support" >> depends on DRM -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)