Re: [PATCH 09/10] dt-bindings: arm: apple: Add M4 based devices

On 7/14/26 21:50, Sven Peter wrote:
>
>
> On 7/5/26 15:17, Yureka Lilian wrote:
>> The Apple devices with the t8132 SoC (M4) are very similar to their M3
>> predecessors.
>>
>> In addition to the MacBook Pro and the various MacBook Air and iMac
>> variants, a Mac mini is offered again with the M4.
>>
>> Signed-off-by: Yureka Lilian <[email protected]>
>> ---
>>   Documentation/devicetree/bindings/arm/apple.yaml | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml 
>> b/Documentation/devicetree/bindings/arm/apple.yaml
>> index e49403c73f9d..3262292252d2 100644
>> --- a/Documentation/devicetree/bindings/arm/apple.yaml
>> +++ b/Documentation/devicetree/bindings/arm/apple.yaml
>> @@ -315,6 +315,18 @@ properties:
>>             - const: apple,t8122
>>             - const: apple,arm-platform
>
> Please also add M4 to the top of the binding in the description.
Ack
>>   +      - description: Apple M4 SoC based platforms
>> +        items:
>> +          - enum:
>> +              - apple,j604  # MacBook Pro (14-inch, M4, 2024)
>> +              - apple,j623  # iMac (24-inch, 2x USB-C, M4, 2024)
>> +              - apple,j624  # iMac (24-inch, 4x USB-C, M4, 2024)
>> +              - apple,j713  # MacBook Air (13-inch, M3, 2025)
>> +              - apple,j715  # MacBook Air (15-inch, M3, 2025)
> Copy/paste errors: these two should be M4 as well and I think the ones 
> at the top should be 2025 instead of 2024, shouldn't they?
I have the M3->M4 typo fixes queued locally. Only the MacBook Air was 
released in 2025, the others in 2024 (according to Wikipedia at least).
>
>
> Best,
>
> Sven


My intention is to rebase and send out v2 with the fixes I've 
accumulated locally once the M3 Pro/Max device trees have been merged 
into apple-soc.



Thanks,

— Yureka