Re: [PATCH v2 6/6] platform/x86: thinkpad_acpi: Convert to use acpi_dev_is_video_device() helper

Ilpo Järvinen <[email protected]> Mon, 20 Jul 2026 13:33:01 +0300 (EEST)

Newsgroups	org.kernel.vger.linux-i2c,org.kernel.vger.linux-acpi,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kernel.vger.platform-driver-x86
Message-ID	<[email protected]>

On Tue, 14 Jul 2026, Andy Shevchenko wrote:

> Replace open coded variant of acpi_dev_is_video_device() helper.
> 
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
>  drivers/platform/x86/lenovo/thinkpad_acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> index 6dd7c28fc0db..aaeada46a0e7 100644
> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> @@ -774,7 +774,7 @@ static acpi_status __init tpacpi_acpi_handle_locate_callback(acpi_handle handle,
>  	if (!strcmp(context, "video")) {
>  		struct acpi_device *dev = acpi_fetch_acpi_dev(handle);
>  
> -		if (!dev || strcmp(ACPI_VIDEO_HID, acpi_device_hid(dev)))
> +		if (!acpi_dev_is_video_device(dev))
>  			return AE_OK;

Acked-by: Ilpo Järvinen <[email protected]>

-- 
 i.