Re: [PATCH] i2c: qup: Propagate clock enable failures

Andi Shyti <[email protected]> Tue, 28 Jul 2026 23:45:13 +0200

Newsgroups	org.kernel.vger.linux-i2c,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

Hi Pengpeng,

On Wed, Jun 24, 2026 at 01:52:37PM +0800, Pengpeng Hou wrote:
> The QUP I2C driver treats the core and iface clocks as required
> resources, but qup_i2c_enable_clocks() ignores clk_prepare_enable()
> failures.  Probe can then continue to register the I2C adapter, and
> runtime/system resume can return success, even when a required clock
> transition failed.
> 
> Make the helper return an error, unwind a partially enabled clock, and
> propagate failures from probe and resume paths.
> 
> Signed-off-by: Pengpeng Hou <[email protected]>

merged to i2c/i2c.

Thanks,
Andi