Re: [PATCH v4 1/3] dt-bindings: i2c: Add Novatek NT72676 I2C controller

On Thu, Jul 30, 2026 at 03:25:27PM +0800, [email protected] wrote:
> diff --git a/Documentation/devicetree/bindings/i2c/novatek,nt72676-i2c.yaml b/Documentation/devicetree/bindings/i2c/novatek,nt72676-i2c.yaml
> new file mode 100644
> index 000000000000..8e2595f882c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/novatek,nt72676-i2c.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/novatek,nt72676-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT72676 I2C Controller
> +
> +maintainers:
> +  - Ben Huang <[email protected]>
> +  - Jason JJ Wu <[email protected]>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  Novatek NT72676 SoC provides two I2C controller variants: generic I2C and
> +  STBC I2C.
> +  The generic I2C controllers are accessible only by the host CPU and driven
> +  by a 96 MHz AHB clock.
> +  On the other hand, the STBC I2C controllers can be controlled by either the
> +  host CPU or STBC (Standby Controller, an 8051-based microcontroller) and
> +  driven by a 12 MHz STBC clock. Authentication with STBC is required before
> +  the host CPU can access the STBC I2C controller registers.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - novatek,nt72676-i2c
> +      - novatek,nt72676-stbc-i2c
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clock-frequency:
> +    default: 100000
> +    enum: [ 100000, 400000 ]
> +
> +  novatek,stbc-syscon:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the STBC system controller registers used to authenticate
> +      host access and switch ownership of the STBC I2C controller.
> +

You miss clocks.

Best regards,
Krzysztof