Re: [PATCH] i2c: core: document preference for i2c_get_adapter_by_fwnode()
Wolfram Sang <[email protected]> Sat, 1 Aug 2026 22:57:34 +0200
| Newsgroups | org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <am5dvgXS09CA3ohj@shikoro> |
--SJ5bFrbXcgFDxfRE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 16, 2026 at 03:30:29PM +0200, Johan Hovold wrote: > The i2c subsystem currently blocks during adapter deregistration > whenever there are consumers holding a reference. >=20 > Document that i2c_get_adapter_by_fwnode(), which also takes a module > reference, should almost always be preferred over > i2c_find_adapter_by_fwnode() so that an attempt to unload the adapter > module while in use fails gracefully instead of blocking > uninterruptibly. >=20 > Note that by implication of_get_i2c_adapter_by_node() is also generally > preferred over of_find_i2c_adapter_by_node(). >=20 > Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Wolfram Sang <[email protected]> Andi, I would suggest to apply it to for-current even, because this is an important doc update, but I'll leave it to you, of course. --SJ5bFrbXcgFDxfRE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmpuXb4ACgkQFA3kzBSg KbZ94g/+PlE1D7FkiFaiypGmN4Lqa8HtAnPrwgHaAef11FHJHzpEucbxSxOu2HPB BMV7djxEE2X1sQ6RHSMLSqVNMC/5UeFLGQKx6a+44xzLi6XRH3eT/HInNIXT/W0N oP1z22ILzhIs5Z+OPp2rTW92sO2PT+Jl5Bjg2jxO2DlCtQtqLs7WokKqx+WmcH6r TJXlZ3QLpopmZtbkuNskPbL1W0omisVH77szj24VjgrIrJC8+LsyB7DAmbfze0zM XJT1InNPsIhDxykfUlNjS+ARIXVJDECzcli0naIObN+pVkPqEWDq0G2cGrFjcuij 4L7ytWWMFgPx5yxGaumcrJI/LhGSFRB4K2qqYl5pcFfNnMj1Dcl0wB1r6GEsYQQn X2Hw7soAON7w/TQ9yApj2Mj/J8LsJVEqDFQnINdFctvuSscii47nj968N7/o9XzE aM9e2d5H2UaASdRCmIJft5TDuQDBlvYi/k9+pE2/JymMtMay/iDktGHW2ExTls42 2UvVHbubrkMs3wbq9D1g0OB8Sua+AwSSCffXX6qclMqfXpGFomECWrrZvIgcw6V/ nJiXjhQPtLbW2nOy1frWyk4vlc4dxPglIj6Vw+QXx9BbUKtl0hZ4OR6r8G9TKRIl 9Qi5HOLN/29wr2+kwiy0dH76sAGWmHV/lq/hrazHE3KRo4jVpwA= =+k5l -----END PGP SIGNATURE----- --SJ5bFrbXcgFDxfRE--