Re: [PATCH v9 4/6] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support
Daniel Lezcano <[email protected]> Fri, 7 Aug 2026 04:34:11 +0200
| Newsgroups | org.kernel.vger.linux-i2c,dev.linux.lists.mfd,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <[email protected]> |
On 8/5/26 10:06, Ronald Claveau via B4 Relay wrote: > From: Ronald Claveau <[email protected]> > > Replace the hardcoded MAX_LEVEL constant and fan register > with values read from platform_data (fan_reg, levels[] and nlevels), > as new MCUs need different values. > > The cooling device's state is stored as an index into levels[], > and khadas_mcu_fan_set_level() writes levels[state] to fan_reg, > rather than writing the raw state value as before. > > Optionally acquire and enable a "fan" regulator supply > at probe time and on resume, > so boards that gate fan power through a regulator are handled. > > Reviewed-by: Neil Armstrong <[email protected]> > Signed-off-by: Ronald Claveau <[email protected]> > --- * Through which tree this patch should go ? (assuming there is a dependency on other patches) * How this will behave with 100 levels with the step wise governor ? For a 100ms passive delay and 100 states, it will take 10s before reaching the full speed