Re: [PATCH v3] ACPI: APD: Add clock frequency for HJMC01 I2C controller

On Tue, Aug 11, 2026 at 09:54:33AM +0300, Andy Shevchenko wrote:

> On Tue, Aug 11, 2026 at 02:22:34PM +0800, clarke.li wrote:
> > On Thu, Aug 06, 2026 at 11:31:01PM +0300, Andy Shevchenko wrote:
> > > On Wed, Jul 22, 2026 at 03:30:31PM +0800, clarke.li wrote:
>
> ...
>
> > > > +	.fixed_clk_rate = 200000000,
> > >
> > > Can you at some point update these constants to use
> > >
> > > 	.fixed_clk_rate = 200 * HZ_PER_MHZ,
> > >
> > > and so on?
> >
> > Thanks for the suggestion, I will use 200 * HZ_PER_MHZ in the
> > next version.
> >
> > By the way, do you also want me to convert the other
> > fixed_clk_rate constants in acpi_apd.c to use HZ_PER_MHZ?
> > If so, I can send it as a separate cleanup patch.
>
> The idea is that you convert existing ones in a separate patch and then use a
> new format for the new hw support.

Understood. I will send the next revision as a two-patch series:

  [PATCH v4 1/2] ACPI: APD: Convert fixed clock rates to HZ_PER_MHZ
  [PATCH v4 2/2] ACPI: APD: Add clock frequency for HJMC01 I2C controller

The first patch converts the existing fixed_clk_rate constants in
acpi_apd.c to use HZ_PER_MHZ, and the second one adds the HJMC01
support using the new format (200 * HZ_PER_MHZ).

--
Thanks,
Hongnan Li