Re: [PATCH 1/2] i2c: qcom-geni: update frequency table to fix timing parameters
Kathiravan Thirumoorthy <[email protected]> Tue, 11 Aug 2026 21:26:45 +0530
| Newsgroups | org.kernel.vger.linux-i2c,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On 8/11/2026 6:12 PM, Mukesh Savaliya wrote: > > > On 8/11/2026 2:53 PM, Kathiravan Thirumoorthy wrote: >> In IPQ5424, to meet the setup and hold timing requirements in the >> standard mode, update the frequency table with the values recommended by > Changes are fore FAST mode too, please update the commit log accordingly. There are no changes to the FAST mode. As mentioned below, I just removed the extra space between values 4 and 3. >> HW design team. >> >> Also remove the stray space in the I2C_MAX_FAST_MODE_FREQ entry. >> >> Cc: <[email protected]> >> Fixes: 85c34532849d ("i2c: qcom-geni: fix I2C frequency table to >> achieve accurate bus rates") >> Fixes: 506bb2ab0075 ("i2c: qcom-geni: Support systems with 32MHz >> serial engine clock") >> Signed-off-by: Kathiravan Thirumoorthy >> <[email protected]> >> --- >> drivers/i2c/busses/i2c-qcom-geni.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c >> b/drivers/i2c/busses/i2c-qcom-geni.c >> index 658636c1ee0e..00013b41a6f5 100644 >> --- a/drivers/i2c/busses/i2c-qcom-geni.c >> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >> @@ -188,8 +188,8 @@ static const struct geni_i2c_clk_fld >> geni_i2c_clk_map_19p2mhz[] = { >> /* source_clock = 32 MHz */ >> static const struct geni_i2c_clk_fld geni_i2c_clk_map_32mhz[] = { >> - { I2C_MAX_STANDARD_MODE_FREQ, 8, 14, 18, 38 }, >> - { I2C_MAX_FAST_MODE_FREQ, 4, 3, 9, 19 }, >> + { I2C_MAX_STANDARD_MODE_FREQ, 12, 9, 10, 26 }, >> + { I2C_MAX_FAST_MODE_FREQ, 4, 3, 9, 19 }, >> { I2C_MAX_FAST_MODE_PLUS_FREQ, 2, 3, 5, 15 }, >> {} >> }; >> >