Re: [PATCH v5 2/4] i2c: add Andes I2C driver support

Ben Zong-You Xie <[email protected]> Wed, 12 Aug 2026 11:31:37 +0800

Newsgroups	org.kernel.vger.linux-i2c,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<anvpGTqOnwlbERgR@swlinux02>

On Tue, Aug 11, 2026 at 09:37:12AM +0200, Christophe JAILLET wrote:
>
> Le 11/08/2026 à 08:29, Ben Zong-You Xie via B4 Relay a écrit :
> > From: Ben Zong-You Xie <[email protected]>
> >
> > Add support for Andes I2C driver. Andes I2C can act as either a
> > controller or a target, depending on the control register settings. Now,
> > we only support controller mode.
> >
> > Signed-off-by: Ben Zong-You Xie <[email protected]>
>

Hi CJ,

> ...
>
> > +static struct i2c_algorithm andes_i2c_algo = {
>
> Could this be const?

Yes, I will add const in v6.

> > +     .xfer = andes_i2c_xfer,
> > +     .functionality = andes_i2c_func,
> > +};
> CJ

Thanks,
Ben