[PATCH v2] i2c: cp2615: handle allocation failure
Triet Hoang <[email protected]>
| Newsgroups | org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Check the result of kzalloc_obj() and return -ENOMEM when the allocation fails instead of passing a NULL pointer to the message initialization helpers, which would return -EINVAL. Signed-off-by: Triet Hoang <[email protected]> --- Changes in v2: - Clarify the commit message to describe the actual behavior change. - Fix coding style regression --- drivers/i2c/busses/i2c-cp2615.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i2c/busses/i2c-cp2615.c b/drivers/i2c/busses/i2c-cp2615.c index 951de6249834..c1275fcad636 100644 --- a/drivers/i2c/busses/i2c-cp2615.c +++ b/drivers/i2c/busses/i2c-cp2615.c @@ -128,6 +128,9 @@ cp2615_i2c_send(struct usb_interface *usbif, struct cp2615_i2c_transfer *i2c_w) struct usb_device *usbdev = interface_to_usbdev(usbif); int res = cp2615_init_i2c_msg(msg, i2c_w); + if (!msg) + return -ENOMEM; + if (!res) res = usb_bulk_msg(usbdev, usb_sndbulkpipe(usbdev, IOP_EP_OUT), msg, ntohs(msg->length), NULL, 0); @@ -176,6 +179,9 @@ static int cp2615_check_iop(struct usb_interface *usbif) struct usb_device *usbdev = interface_to_usbdev(usbif); int res = cp2615_init_iop_msg(msg, iop_GetAccessoryInfo, NULL, 0); + if (!msg) + return -ENOMEM; + if (res) goto out; -- 2.53.0