Re: [PATCH v2] i2c: qcom-cci: fix device_node refcount leak in cci_probe()/cci_remove()

Liu Zhenlong <[email protected]>
Newsgroups org.kernel.vger.linux-i2c
Message-ID <[email protected]>
Hi Vladimir,

Thanks for the review and the Reviewed-by!

On the cast: I considered (void (*)(void *))of_node_put, but kept the
small wrapper.  Casting to an incompatible function pointer type and
calling through it is technically undefined, and tegra_dc_of_node_put()
in drivers/gpu/drm/tegra/rgb.c uses the same one-line wrapper around
of_node_put(), so I followed that existing pattern.  Happy to switch
to the cast if you'd still prefer it.

Regards,
Liu Zhenlong
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.