Re: [PATCH RFC 12/22] drivers: base: Print a warning instead of panic() when register_cpu() fails
Jonathan Cameron <[email protected]> Tue, 28 Nov 2023 15:05:01 +0000
| Newsgroups | org.kernel.vger.linux-ia64,dev.linux.lists.kvmarm,dev.linux.lists.loongarch,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-riscv,org.kernel.vger.linux-acpi,org.kernel.vger.linux-arch,org.kernel.vger.linux-csky,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-parisc,org.kernel.vger.linux-pm |
|---|---|
| Organization | Huawei Technologies Research and Development (UK) Ltd. |
| Message-ID | <[email protected]> |
On Tue, 07 Nov 2023 10:30:20 +0000 Russell King <[email protected]> wrote: > From: James Morse <[email protected]> > > loongarch, mips, parisc, riscv and sh all print a warning if > register_cpu() returns an error. Architectures that use > GENERIC_CPU_DEVICES call panic() instead. > > Errors in this path indicate something is wrong with the firmware > description of the platform, but the kernel is able to keep running. > > Downgrade this to a warning to make it easier to debug this issue. > > This will allow architectures that switching over to GENERIC_CPU_DEVICES > to drop their warning, but keep the existing behaviour. > > Signed-off-by: James Morse <[email protected]> > Reviewed-by: Russell King (Oracle) <[email protected]> > Signed-off-by: Russell King (Oracle) <[email protected]> I guess there may be paths later that were never exposed because of this panic, but any such should be fixed rather than relying on this big hammer. Reviewed-by: Jonathan Cameron <[email protected]>