Re: [PATCH RFC 15/22] x86/topology: Switch over to GENERIC_CPU_DEVICES

Jonathan Cameron <[email protected]> Tue, 28 Nov 2023 15:16:40 +0000

Newsgroups	org.kernel.vger.linux-ia64,dev.linux.lists.kvmarm,dev.linux.lists.loongarch,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-riscv,org.kernel.vger.linux-acpi,org.kernel.vger.linux-arch,org.kernel.vger.linux-csky,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-parisc,org.kernel.vger.linux-pm
Organization	Huawei Technologies Research and Development (UK) Ltd.
Message-ID	<[email protected]>

On Tue, 07 Nov 2023 10:30:35 +0000
Russell King <[email protected]> wrote:

> From: James Morse <[email protected]>
> 
> Now that GENERIC_CPU_DEVICES calls arch_register_cpu(), which can be
> overridden by the arch code, switch over to this to allow common code
> to choose when the register_cpu() call is made.
> 
> x86's struct cpus come from struct x86_cpu, which has no other members
> or users. Remove this and use the version defined by common code.
> 
> This is an intermediate step to the logic being moved to drivers/acpi,
> where GENERIC_CPU_DEVICES will do the work when booting with acpi=off.
> 
> This patch also has the effect of moving the registration of CPUs from
> subsys to driver core initialisation, prior to any initcalls running.
> 
> Signed-off-by: James Morse <[email protected]>
> Signed-off-by: Russell King (Oracle) <[email protected]>
In perfect world, I'd have liked the structure squash done as a precursor
as then the patch would have been a little less noisy.

However, sometimes it's just not worth the effort.

Reviewed-by: Jonathan Cameron <[email protected]>