Re: [PATCH 04/21] Loongarch: remove arch_*register_cpu() exports

Jonathan Cameron <[email protected]> Thu, 30 Nov 2023 16:48:40 +0000

Newsgroups	org.kernel.vger.linux-ia64,dev.linux.lists.kvmarm,dev.linux.lists.loongarch,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-riscv,org.kernel.vger.linux-acpi,org.kernel.vger.linux-arch,org.kernel.vger.linux-csky,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-parisc,org.kernel.vger.linux-pm
Organization	Huawei Technologies Research and Development (UK) Ltd.
Message-ID	<[email protected]>

On Tue, 21 Nov 2023 13:44:10 +0000
"Russell King (Oracle)" <[email protected]> wrote:

> arch_register_cpu() and arch_unregister_cpu() are not used by anything
> that can be a module - they are used by drivers/base/cpu.c and
> drivers/acpi/acpi_processor.c, neither of which can be a module.
> 
> Remove the exports.
> 
> Reviewed-by: Gavin Shan <[email protected]>
> Signed-off-by: Russell King (Oracle) <[email protected]>

Reviewed-by: Jonathan Cameron <[email protected]>

> ---
>  arch/loongarch/kernel/topology.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/loongarch/kernel/topology.c b/arch/loongarch/kernel/topology.c
> index 3fd166006698..ae860fe81536 100644
> --- a/arch/loongarch/kernel/topology.c
> +++ b/arch/loongarch/kernel/topology.c
> @@ -25,7 +25,6 @@ int arch_register_cpu(int cpu)
>  
>  	return ret;
>  }
> -EXPORT_SYMBOL(arch_register_cpu);
>  
>  void arch_unregister_cpu(int cpu)
>  {
> @@ -34,7 +33,6 @@ void arch_unregister_cpu(int cpu)
>  	c->hotpluggable = 0;
>  	unregister_cpu(c);
>  }
> -EXPORT_SYMBOL(arch_unregister_cpu);
>  #endif
>  
>  static int __init topology_init(void)