[PATCH v1 0/6] Improve ata_scsi_report_supported_opcodes()

Damien Le Moal <[email protected]>
Newsgroups org.kernel.vger.linux-ide
Message-ID <[email protected]>
The implementation of ata_scsi_report_supported_opcodes() mostly satisfies
the internal use when an ATA device is probed from the SCSI layer, but it
is very incomplete. The code is also not very flexible for extending
support for new commands.

This patch series address these issues, cleaning up the implementation and
making REPORT SUPPORTED OPERATION CODES fully functional. E.g., with these
changes, sg_opcodes can be used for listing all SCSI commands that are
supported by libata-scsi and a device.

Example:

     # sg_opcodes /dev/sda
       ATA       WDC  WUH722626AL  WZ41
       Peripheral device type: disk
    
     Opcode  Service    CDB  RWCDLP,  Name
     (hex)   action(h)  size   CDLP
     -----------------------------------------------
      00                  6    0,0    Test Unit Ready
      01                  6    0,0    Rezero Unit
      03                  6    0,0    Request Sense
      08                  6    0,0    Read(6)
      0a                  6    0,0    Write(6)
      0b                  6    0,0    Seek(6)
      12                  6    0,0    Inquiry
      15                  6    0,0    Mode select(6)
      1a                  6    0,0    Mode sense(6)
      1b                  6    0,0    Start stop unit
      1d                  6    0,0    Send diagnostic
      25                 10    0,0    Read capacity(10)
      28                 10    0,0    Read(10)
      2a                 10    0,0    Write(10)
      2b                 10    0,0    Seek(10)
      2f                 10    0,0    Verify(10)
      35                 10    0,0    Synchronize cache(10)
      55                 10    0,0    Mode select(10)
      5a                 10    0,0    Mode sense(10)
      7f                 32    0,0    Variable length
      85                 16    0,0    ATA pass-through(16)
      88                 16    1,1    Read(16)
      8a                 16    1,2    Write(16)
      8f                 16    0,0    Verify(16)
      91                 16    0,0    Synchronize cache(16)
      93                 16    0,0    Write same(16)
      9e       10        16    0,0    Read capacity(16)
      a0                 12    0,0    Report luns
      a1                 12    0,0    ATA pass-through(12)
      a3        c        12    0,0    Report supported operation codes

Damien Le Moal (6):
  ata: libata: rename ata_dev_is_zac()
  ata: libata-scsi: refactor ata_scsi_report_supported_opcodes()
  ata: libata-scsi: improve service action support in
    ata_scsi_report_supported_opcodes()
  ata: libata-scsi: improves checks for ZBC_IN and ZBC_OUT commands
    support
  ata: libata-scsi: support reporting options 2 in REPORT SUPPORTED
    OPERATION CODES
  ata: libata-scsi: support the all command format for reporting
    supported commands

 drivers/ata/libata-core.c |   6 +-
 drivers/ata/libata-scsi.c | 252 +++++++++++++++++++++++++++++---------
 drivers/ata/libata.h      |   2 +-
 3 files changed, 199 insertions(+), 61 deletions(-)

-- 
2.54.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.