Re: [PATCH v2] ata: libata-scsi: limit simulated SCSI command copy to response length
Damien Le Moal <[email protected]>
| Newsgroups | org.kernel.vger.linux-ide,dev.linux.lists.sashiko-reviews |
|---|---|
| Organization | Western Digital Research |
| Message-ID | <[email protected]> |
On 7/2/26 11:14, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > > Pre-existing issues: > - [Critical] The defensive bounds check `WARN_ON(len > ATA_SCSI_RBUF_SIZE)` is ineffective because it evaluates after the `actor` callback has already performed an out-of-bounds write. Karuna, Sashiko has a good point here. Let's work on fixing this with an incremental patch. -- Damien Le Moal Western Digital Research