Re: [PATCH v2 4/5] ata: libata-scsi: support reporting options 2 in REPORT SUPPORTED OPERATION CODES

On Thu, Jul 02, 2026 at 04:00:18PM +0900, Damien Le Moal wrote:
> > According to SPC-5, option 2 queries for unsupported commands (and similarly,
> > option 1 queries for commands with service actions) must return SUPPORT=001b.
> > Instead, this implementation erroneously aborts the command by calling
> > ata_scsi_set_invalid_field(), preventing the code from falling through and
> > correctly populating the response buffer.
> 
> Sashiko, please reread the SPC specifications. It says:
> 
> If the REQUESTED OPERATION CODE field specifies an operation code for
> which the device server does not implement service actions a, then the
> device server shall terminate the command with CHECK CONDITION
> status, with the sense key set to ILLEGAL REQUEST, and the additional
> sense code set to INVALID FIELD IN CDB.
> 
> Which is exactly what we are testing here.

This is a bit funny :D

It would be nice if Sashiko actually listened (like a real AI agent),
re-read the spec, and updated posted an updated review comment :)

Perhaps try to include the SPC spec excerpt in the commit message for V3,
and see if that helps Sashiko parse the spec correctly ? :)


Kind regards,
Niklas