Re: [PATCH v2 2/5] ata: libata-scsi: refactor ata_scsi_report_supported_opcodes()
Niklas Cassel <[email protected]>
| Newsgroups | org.kernel.vger.linux-ide,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <akZ7getxFWS7dYpe@ryzen> |
On Thu, Jul 02, 2026 at 04:48:16PM +0200, Christoph Hellwig wrote: > Who still cares about TRIM on ATA these days to bother with any > of this? > Have you not heard, ATA SSDs are coming back: https://www.tomshardware.com/pc-components/ssds/sandisk-brings-back-affordable-storage-to-rescue-buyers-from-the-ssd-crisis-new-320-and-520-sata-ssds-are-ready-to-launch :) Seriously though, was mostly interested to hear you opinion wrt. if WRITE SAME (16) should be exposed in REPORT SUPPORTED OPERATION CODES. But with all the information I have, I still think it is better to just continue to using WRITE SAME (16) internally as an intermediate command for REQ_OP_DISCARD, and not expose support in REPORT SUPPORTED OPERATION CODES. Kind regards, Niklas