Re: [PATCH v3 1/9] ata: don't store pci_device_id

Damien Le Moal <[email protected]> Tue, 7 Jul 2026 10:12:34 +0900
Newsgroups org.kernel.vger.linux-ide,dev.linux.lists.driver-core,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kernel.vger.linux-scsi,org.kernel.vger.netdev
Organization Western Digital Research
Message-ID <[email protected]>
On 7/6/26 23:11, Gary Guo wrote:
> pci_device_id is not guaranteed to live longer than probe due to presence
> of dynamic ID. All information apart from driver_data can be easily
> retrieved from pci_dev, so just store driver_data.
> 
> Reviewed-by: Danilo Krummrich <[email protected]>
> Signed-off-by: Gary Guo <[email protected]>

Looks good, but please change the commit title to:

ata: ata_generic: don't store pci_device_id

With that,

Acked-by: Damien Le Moal <[email protected]>


-- 
Damien Le Moal
Western Digital Research