Re: [PATCHv3 1/5] ata: sata_dwc_460ex: use platform_get_irq()

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch removes the local variable `np` from `sata_dwc_probe()`, causing a build failure when `CONFIG_SATA_DWC_OLD_DMA` is enabled.
--

--- Patch [1]: [PATCHv3 1/5] ata: sata_dwc_460ex: use platform_get_irq() ---
commit 74bc1be9c4385029a4079d000bf78ff4452fc266
Author: Rosen Penev <[email protected]>

ata: sata_dwc_460ex: use platform_get_irq()

This commit replaces irq_of_parse_and_map() with platform_get_irq() in both
sata_dwc_dma_init_old() and sata_dwc_probe(). It improves error handling for
IRQs and removes the unnecessary include of of_irq.h.

> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 4fc22ce4bd9aa..442c6e9d06e0a 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c

[ ... ]

> @@ -1126,7 +1122,6 @@ static const struct ata_port_info sata_dwc_port_info[] = {
>  static int sata_dwc_probe(struct platform_device *ofdev)
>  {
>  	struct device *dev = &ofdev->dev;
> -	struct device_node *np = dev->of_node;
>  	struct sata_dwc_device *hsdev;
>  	u32 idr, versionr;
>  	char *ver = (char *)&versionr;

[ ... ]

> @@ -1173,11 +1168,9 @@ static int sata_dwc_probe(struct platform_device *ofdev)
>  	sata_dwc_enable_interrupts(hsdev);
>  
>  	/* Get SATA interrupt number */
> -	irq = irq_of_parse_and_map(np, 0);
> -	if (!irq) {
> -		dev_err(dev, "no SATA DMA irq\n");
> -		return -ENODEV;
> -	}
> +	irq = platform_get_irq(ofdev, 0);
> +	if (irq < 0)
> +		return irq;
>  
>  #ifdef CONFIG_SATA_DWC_OLD_DMA
>  	if (!of_property_present(np, "dmas")) {

[Severity: Low]
Will this cause a build failure when compiling with CONFIG_SATA_DWC_OLD_DMA
enabled?

The earlier hunk removes the declaration of the np variable, but it appears
to still be referenced here in sata_dwc_probe(). Could dev->of_node be passed
to of_property_present() instead to avoid an undeclared identifier error?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1