Re: [PATCH] ata: pata_ep93xx: add missing "cc" clobber to inline asm

Damien Le Moal <[email protected]> Tue, 21 Jul 2026 08:02:31 +0900

Newsgroups	org.kernel.vger.linux-ide,org.kernel.vger.linux-kernel
Organization	Western Digital Research
Message-ID	<[email protected]>

On 7/21/26 06:09, Rosen Penev wrote:
> On Mon, Jun 1, 2026 at 11:35 AM Rosen Penev <[email protected]> wrote:
>>
>> The inline assembly in ep93xx_pata_delay() uses a "subs" instruction
>> which modifies the ARM condition code flags. Add a "cc" clobber so
>> the compiler knows the flags are altered. Without it, the compiler may
>> reorder flag-dependent instructions across the asm block when the
>> function is inlined, potentially causing incorrect control flow.
>>
>> Assisted-by: Opencode:Big-Pickle
>> Signed-off-by: Rosen Penev <[email protected]>
> should I resend?

Oops. This fell through the cracks. Yes, please resend and add a fixes tag as well.

-- 
Damien Le Moal
Western Digital Research