Re: [PATCH] ata: pata_pxa: use devres for DMA channel management

On 7/20/26 11:01, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The commit message falsely claims that `ata_host_activate()` registers a managed host detach and that the patch preserves the previous teardown ordering.
> --
> 
> --- Patch [1]: [PATCH] ata: pata_pxa: use devres for DMA channel management ---
> commit d581effc5d41a82779ae2b411de235a8efbfb017
> Author: Rosen Penev <[email protected]>
> 
> ata: pata_pxa: use devres for DMA channel management
> 
> Convert the DMA channel request to devm_dma_request_chan() so the
> channel is released automatically on device teardown. This removes
> the explicit dma_release_channel() calls in the probe error paths
> and in pxa_ata_remove().
> 
>> Devres releases in LIFO order, so the managed host detach registered
>> by ata_host_activate() runs before the DMA channel is released, which
>> preserves the previous teardown ordering.
> 
> [Severity: Medium]
> Is this description accurate regarding the managed host detach and teardown
> ordering?

Rosen,

Can you resend with a fixed up commit message?
Thanks.

-- 
Damien Le Moal
Western Digital Research