Re: [PATCH v4 9/9] PCI: Fix UAF when probe runs concurrent to dyn ID removal

[email protected] Fri, 24 Jul 2026 22:02:09 +0000
Newsgroups org.kernel.vger.linux-ide,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-pci,org.kernel.vger.linux-scsi
Message-ID <[email protected]>
> Dynamic IDs are only guaranteed to be valid when dynids.lock is held,
> as remove_id_store() can free the node. Thus, make a copy in
> pci_match_device(). Also, clarify that the id parameter is only valid
> during probe.
>=20
> Reported-by: Sashiko <[email protected]>
> Link: https://lore.kernel.org/all/[email protected]=
.org/
> Fixes: 0994375e9614 ("PCI: add remove_id sysfs entry")
> Reviewed-by: Danilo Krummrich <[email protected]>
> Signed-off-by: Gary Guo <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260723-pci_id_fix=
[email protected]?part=3D9