Re: [PATCH v2 12/13] treewide: convert rdmsrq() from a macro to an inline function

[email protected] Wed, 19 Aug 2026 10:44:21 +0000

Newsgroups	org.kernel.vger.linux-ide,org.freedesktop.lists.dri-devel,org.kernel.vger.kvm,org.kernel.vger.linux-hwmon,org.kernel.vger.linux-hyperv,org.kernel.vger.linux-pci,org.kernel.vger.linux-perf-users
Message-ID	<[email protected]>

> Today rdmsrq() is a macro using its second parameter as the target for
> storing the read MSR value.
> 
> Convert rdmsrq() to an inline function returning the MSR value.
> 
> The users have been converted using the following semantic patch:
> 
>   // Options: --include-headers
> 
>   virtual patch
>   virtual report
> 
>   @@
>   expression msr, val;
>   @@
>   (
>   - rdmsrq(msr,val)
>   + val = rdmsrq(msr)
>   )
> 
> Signed-off-by: Juergen Gross <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12