Re: [PATCH 4/7] staging: iio: adt7316: Remove redundant dev_err()

On Mon, 20 Jul 2026 21:43:10 +0800
Pan Chuang <[email protected]> wrote:

> Since commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
> devm_request_threaded_irq() automatically logs detailed error messages
> on failure. Remove the now-redundant driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <[email protected]>
Applied to the testing branch of iio.git

Thanks,

Jonathan

> ---
>  drivers/staging/iio/addac/adt7316.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 59fb3bd26bc1..20f6052cc7fb 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -1814,11 +1814,8 @@ static int adt7316_setup_irq(struct iio_dev *indio_dev)
>  					NULL, adt7316_event_handler,
>  					irq_type | IRQF_ONESHOT,
>  					indio_dev->name, indio_dev);
> -	if (ret) {
> -		dev_err(&indio_dev->dev, "failed to request irq %d\n",
> -			chip->bus.irq);
> +	if (ret)
>  		return ret;
> -	}
>  
>  	if (irq_type & IRQF_TRIGGER_HIGH)
>  		chip->config1 |= ADT7316_INT_POLARITY;