[PATCH v2 09/13] iio: magnetometer: Remove redundant dev_err()
Pan Chuang <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <[email protected]>
---
drivers/iio/magnetometer/ak8974.c | 5 +----
drivers/iio/magnetometer/rm3100-core.c | 4 +---
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8974.c b/drivers/iio/magnetometer/ak8974.c
index c7fdb7c2f543..28d6cadfd9f8 100644
--- a/drivers/iio/magnetometer/ak8974.c
+++ b/drivers/iio/magnetometer/ak8974.c
@@ -926,11 +926,8 @@ static int ak8974_probe(struct i2c_client *i2c)
irq_trig,
ak8974->name,
ak8974);
- if (ret) {
- dev_err(&i2c->dev, "unable to request DRDY IRQ "
- "- proceeding without IRQ\n");
+ if (ret)
goto no_irq;
- }
ak8974->drdy_irq = true;
}
diff --git a/drivers/iio/magnetometer/rm3100-core.c b/drivers/iio/magnetometer/rm3100-core.c
index ac3f9f7fc808..46fce2978d76 100644
--- a/drivers/iio/magnetometer/rm3100-core.c
+++ b/drivers/iio/magnetometer/rm3100-core.c
@@ -568,10 +568,8 @@ int rm3100_common_probe(struct device *dev, struct regmap *regmap, int irq)
IRQF_ONESHOT,
indio_dev->name,
indio_dev);
- if (ret < 0) {
- dev_err(dev, "request irq line failed.\n");
+ if (ret)
return ret;
- }
data->drdy_trig = devm_iio_trigger_alloc(dev, "%s-drdy%d",
indio_dev->name,
--
2.34.1