Re: [PATCH v8 2/5] iio: adc: ltc2378: Add support for LTC2378-20 and similar ADCs

On 07/23, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The IIO scale factor exported for the LTC2338-18 is incorrect due to an unaccounted internal resistor divider (missing 2.5x multiplier).
> --
> 
> --- Patch [2]: [PATCH v8 2/5] iio: adc: ltc2378: Add support for LTC2378-20 and similar ADCs ---
> commit 79bd7cc98e49057401d7fb8d26685b9092c4787e
> Author: Marcelo Schmitt <[email protected]>
> 
> iio: adc: ltc2378: Add support for LTC2378-20 and similar ADCs
> 
> Support for LTC2378-20 and similar analog-to-digital converters.
> 
> > diff --git a/drivers/iio/adc/ltc2378.c b/drivers/iio/adc/ltc2378.c
> > new file mode 100644
> > index 0000000000000..107388f870626
> > --- /dev/null
> > +++ b/drivers/iio/adc/ltc2378.c
> [ ... ]
> > +static const struct ltc2378_chip_info ltc2338_18_chip_info = {
> > +	.name = "ltc2338-18",
> > +	.internal_ref_uV = 2048000,
> > +	.chan = LTC2378_DIFF_CHANNEL(18),
> > +};
> 
> [Severity: Medium]
> Does this chip info need a field to indicate the scale multiplier?
> 
> The LTC2338-18 has an internal resistor divider which acts as a 2.5x multiplier,
> but this struct doesn't currently contain a way to specify it.

I guess it makes sense. Might split support for this specific part into a
separate patch to avoid it holding on the rest of the series in v9.