Re: [PATCH 1/2] iio: light: veml3328: remove unused i2c_set_clientdata()

On Sun, 26 Jul 2026 20:15:25 +0100
Jonathan Cameron <[email protected]> wrote:

> On Fri, 24 Jul 2026 00:07:08 +0200
> Joshua Crofts <[email protected]> wrote:
> 
> > The I2C client data is set but never used. Remove the unnecessary
> > function call.  
> Yes it is.  Take another look at how that works and how else the resulting
> data is accessed (or just look at Sashiko)
> 
> I was hoping it would catch this one :)
> 
> The combination of different interfaces to access the same data has
> been much debated over time but we never came to a conclusion on whether
> it was worth the effort of stopping doing so given i2c driver reviewers
> are far too familiar with this particular hole.
> 

Ugh, I was too hasty - I read Sashiko's review a few hours later and
realized what (very stupid) mistake I made.


-- 
Kind regards,
Joshua Crofts