Re: [PATCH] iio: light: veml3328: remove redundant cast in read_avail
Jonathan Cameron <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260728223848.5736c529@jic23-huawei> |
On Mon, 27 Jul 2026 17:50:23 +0400 Giorgi Tchankvetadze <[email protected]> wrote: > On Mon, Jul 27, 2026 at 5:16 PM David Lechner <[email protected]> wrote: > > > > Usually, we would declare the array like: > > > > static const int veml3328_scale_vals[4][4][2] ... > > > > in which case this cast would be needed. > > > > > I intentionally kept the patch tiny and dealt with the obvious thing, > but yes, I agree this is how it should be done. I think it is worth making the more complex change to improve the readability more generally. So if you don't mind, please do that for v2. Jonathan