Re: [PATCH v2 2/2] iio: adc: ti-ads112c04: Add support for TI ADS112C04

David Lechner <[email protected]> Fri, 31 Jul 2026 10:09:16 -0500

Newsgroups	org.kernel.vger.linux-iio,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On 7/31/26 9:54 AM, David Lechner wrote:
> On 7/30/26 9:58 PM, Kyle Hsieh wrote:
>> Add IIO driver support for the Texas Instruments ADS112C04 (16-bit)
>> delta-sigma ADCs.
>>

...

>> +	st->config0 = 0x01;
> 
> Needs a macro and FIELD_PREP().

Correction: This one is a bit, so FIELD_PREP() is not needed.

> 
> Also, since we are parsing channels now, can/should we leave PGA enabled
> for diff-channels? Otherwise add a comment explaining current choice.
>