Re: [PATCH v3 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe()

On Sun,  2 Aug 2026 16:05:20 +0530
[email protected] wrote:

> From: Mohammad Shahid <[email protected]>
> 
> Hi Jonathan,
> 
> Thanks for the detailed review and suggestions.
> 
> I'll address the formatting comments in patch 3 and also reduce the
> unnecessary churn in patch 2 as you suggested.
> 
> Regarding the suggestion to convert the probe cleanup to
> devm_add_action_or_reset(), my intention was to keep this series focused
> on the dev_err_probe() conversion and submit the devm-managed cleanup as
> a separate follow-up series, since it is a larger refactoring.
> 
> Would that approach be acceptable, or would you prefer that the cleanup
> be included in this series?

I'd leave the dev_err() prints where there is a goto alone
and do them as part of the devm_ change so as to reduce churn on
the code and shorter the eventual set of patches.

Just add a note to the dev_err_probe() patch to say you are doing
that and then they can be separate series.

Or if you prefer just do the lot in one series.

Thanks

Jonathan

> 
> Thanks,
> Shahid