Re: [PATCH v4 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages

On Sat,  1 Aug 2026 14:39:51 +0530
[email protected] wrote:

> From: Mohammad Shahid <[email protected]>
> 
> devm_request_threaded_irq() already logs an error when the request
> fails, making the explicit dev_err() redundant.
> 
> Similarly, iproc_adc_enable() already reports failures, making the
> additional dev_err() in the probe path redundant.
> 
> Remove both duplicate messages.
> 
> Signed-off-by: Mohammad Shahid <[email protected]>
> ---
>  drivers/iio/adc/bcm_iproc_adc.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
> index cf4738b16e62..7c2e2770cd61 100644
> --- a/drivers/iio/adc/bcm_iproc_adc.c
> +++ b/drivers/iio/adc/bcm_iproc_adc.c
> @@ -551,10 +551,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
>  				iproc_adc_interrupt_handler,
>  				iproc_adc_interrupt_thread,
>  				IRQF_SHARED, "iproc-adc", indio_dev);
> -	if (ret) {
> -		dev_err(&pdev->dev, "request_irq error %d\n", ret);
> +	if (ret)
>  		return ret;
> -	}
>  
>  	ret = clk_prepare_enable(adc_priv->adc_clk);
>  	if (ret) {
> @@ -564,10 +562,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
>  	}
>  
>  	ret = iproc_adc_enable(indio_dev);
> -	if (ret) {
> -		dev_err(&pdev->dev, "failed to enable adc %d\n", ret);
> +	if (ret)
>  		goto err_adc_enable;
> -	}
>  
>  	indio_dev->name = "iproc-static-adc";
>  	indio_dev->info = &iproc_adc_iio_info;

This is good.

Side note - I noticed that you added the email [email protected] to the
Cc list, however I don't work at Broadcom - there must've been a mixup when you
were Ccing people as I only use the address this meesage is sent from.

Thanks.

-- 
Kind regards,
Joshua Crofts