Re: [PATCH v3 3/3] iio: dac: add support for Microchip MCP48FEB02

On Tue, Aug 4, 2026 at 4:30 PM Ariana Lazar <[email protected]> wrote:
>
> This is the iio driver for Microchip MCP48FxBy1/2/4/8 series of buffered

IIO

> voltage output Digital-to-Analog Converters with nonvolatile or volatile
> memory and an SPI Interface.
>
> The families support up to 8 output channels.
>
> The devices can be 8-bit, 10-bit and 12-bit.

...

> +++ b/drivers/iio/dac/mcp47feb02-spi.c


> +#include <linux/dev_printk.h>
> +#include <linux/err.h>

> +#include <linux/export.h>

Not used

> +#include <linux/module.h>
> +#include <linux/pm.h>
> +#include <linux/regmap.h>
> +#include <linux/spi/spi.h>
> +
> +#include "mcp47feb02.h"
> +
> +/* Parts with EEPROM memory */
> +MCP47FEB02_CHIP_INFO(mcp48feb01, 1, 8,  false, true);
> +MCP47FEB02_CHIP_INFO(mcp48feb02, 2, 8,  false, true);

Need a header for 'true' and 'false'.

> +MCP47FEB02_CHIP_INFO(mcp48feb04, 4, 8,  true,  true);
> +MCP47FEB02_CHIP_INFO(mcp48feb08, 8, 8,  true,  true);
> +MCP47FEB02_CHIP_INFO(mcp48feb11, 1, 10, false, true);
> +MCP47FEB02_CHIP_INFO(mcp48feb12, 2, 10, false, true);
> +MCP47FEB02_CHIP_INFO(mcp48feb14, 4, 10, true,  true);
> +MCP47FEB02_CHIP_INFO(mcp48feb18, 8, 10, true,  true);
> +MCP47FEB02_CHIP_INFO(mcp48feb21, 1, 12, false, true);
> +MCP47FEB02_CHIP_INFO(mcp48feb22, 2, 12, false, true);
> +MCP47FEB02_CHIP_INFO(mcp48feb24, 4, 12, true,  true);
> +MCP47FEB02_CHIP_INFO(mcp48feb28, 8, 12, true,  true);

-- 
With Best Regards,
Andy Shevchenko