Re: [PATCH] iio: flow: slf3s: restart measurement if VDD disable fails

On Thu Aug 6, 2026 at 11:39 AM CEST, Nuno Sá wrote:
> On Wed, Aug 05, 2026 at 07:02:55PM +0800, Linmao Li wrote:
>
> I'm also not sure about the above. If the regulator fails to disable I
> would say things are already in a bad state anyways. Is there any strong
> reason to do `slf3s_send_cmd(sf->client, slf3s_cmd_stop_meas)` before
> disabling vdd? I would assume that without vdd things will terminate
> anyways. Asking because if we just disable it then the above stops
> being a question. Though I do understand it's better to gracefully
> terminate things. Just not sure if there's any added value for that in
> this path.

on quite a few boards vdd is tied directly to the always-on rail, so there's
no real supply node in the DT and the regulator core falls back to a dummy regulator there
regulator_disable() becomes a pure no-op that always returns success without  actually removing power.
so we can't rely on cutting vdd to stop the sensor

Wadim

>
> Just my 2 cents. No strong feelings so if the driver author is fine with
> this, also looks like a sensible change.
>
> - Nuno Sá
>
> >  }
> >  
> >  static int slf3s_resume(struct device *dev)
> > 
> > base-commit: 0efaefce4e95a3331550329c0078b2fb38b3ff1f
> > -- 
> > 2.25.1
> >