Re: [PATCH 2/2] iio: accel: adxl367: add support for INT2 interrupt pin

Nuno Sá <[email protected]>
Newsgroups org.kernel.vger.linux-iio,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <178603199582.1212536.12747445371339172232.b4-review@b4>
On Wed, 05 Aug 2026 14:59:52 +0300, Antoniu Miclaus <[email protected]> wrote:
> diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
> index 8c3de11a10a3..229974478d10 100644
> --- a/drivers/iio/accel/adxl367.c
> +++ b/drivers/iio/accel/adxl367.c
> @@ -1482,6 +1507,8 @@ int adxl367_probe(struct device *dev, const struct adxl367_ops *ops,
>  	if (ret)
>  		return ret;
>  
> +	irq = adxl367_get_int_line(st, irq);

On top of Sashiko's points (which do make sense), I'm not sure why we
return irq in adxl367_get_int_line() which seems to be just the same we
passed to it?

-- 
Nuno Sá <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.