Re: [PATCH 1/3] dt-bindings: Add InvenSense ICM-42370-p accelerometer

Kanak Shilledar <[email protected]>
Newsgroups org.kernel.vger.linux-iio,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hi,

Thanks for reviewing the code.

On Fri, 2026-08-07 at 12:16 +0200, Joshua Crofts wrote:
> [You don't often get email from [email protected]. Learn why
> this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On Thu, 6 Aug 2026 14:46:27 +0200
> Kanak Shilledar <[email protected]> wrote:
> 
> > +  vdd-supply:
> > +    description: Regulator operating range between 1.71V to 3.6V.
> > +
> > +  vddio-supply:
> > +    description: Regulator operating range between 1.71V to 3.6V.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> 
> vdd-supply and vddio-supply are definitely required.

Will add them in the dt-binding as well as other properties suggested
by sashiko.
> ...
> 
> > +INVENSENSE ICM-42370P ACCELEROMETER
> > +M:   Kanak Shilledar <[email protected]>
> > +M:   Henrik Grimler <[email protected]>
> > +L:   [email protected]
> 
> No need to add the IIO list as get_maintainer will automatically find
> it based on the file path. However I did notice that you have a
> company kernel mailing list, perhaps add that here?

Thanks for pointing that out. We will update it to our company kernel
mailing list (i.e., [email protected]).

> --
> Kind regards,
> Joshua Crofts

Thanks and Regards,
Kanak Shilledar
signature.asc (application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRZbIB7R61KYt5yWsuslrbqDH4eIAUCanXafgAKCRCslrbqDH4e
IPR2AQD7xC5nTviX4ROiPLKNCW/+38talNZm+oOjKSe/QmvgzQD/dy8gH8okVs5l
qMXIKB1bm8+9gV8hS/S3xBGKVtpBAAY=
=1MdC
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.