[PATCH] iio: proximity: srf04: fix runtime PM autosuspend cleanup
Guangshuo Li <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
srf04_probe() calls pm_runtime_use_autosuspend() when the optional
power GPIO is present, but srf04_remove() does not call the matching
pm_runtime_dont_use_autosuspend() before disabling runtime PM.
The runtime PM documentation requires pm_runtime_use_autosuspend() to
be balanced with pm_runtime_dont_use_autosuspend() when the driver is
removed. Failing to do so can leave the autosuspend usage state
unbalanced and may result in a usage_count leak when the autosuspend
delay is negative.
Add the missing pm_runtime_dont_use_autosuspend() call in the remove
path before disabling runtime PM.
This issue was found by manual code inspection.
Fixes: 2251157b335b4 ("iio: srf04: add power management feature")
Signed-off-by: Guangshuo Li <[email protected]>
---
drivers/iio/proximity/srf04.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c
index 7be50bdebfcb..5f270f506803 100644
--- a/drivers/iio/proximity/srf04.c
+++ b/drivers/iio/proximity/srf04.c
@@ -347,6 +347,7 @@ static void srf04_remove(struct platform_device *pdev)
iio_device_unregister(indio_dev);
if (data->gpiod_power) {
+ pm_runtime_dont_use_autosuspend(data->dev);
pm_runtime_disable(data->dev);
pm_runtime_set_suspended(data->dev);
}
--
2.43.0