Re: [PATCH v3 0/2] iio: adc: Add support for Texas Instruments ADS112C04
David Lechner <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/5/26 2:44 AM, Kyle Hsieh wrote: > On Wed, Aug 5, 2026 at 2:46 PM Krzysztof Kozlowski <[email protected]> wrote: >> >> On 05/08/2026 08:43, Krzysztof Kozlowski wrote: >>> On 05/08/2026 07:38, Kyle Hsieh wrote: >>>> This patch series introduces support for the Texas Instruments ADS112C04 >>>> Analog-to-Digital Converters. >>>> >>>> The ADS112C04 (16-bit) is precision, low-power, delta-sigma ADCs with >>>> an I2C interface. They feature a flexible input multiplexer supporting >>>> single-ended and differential measurements, a programmable gain amplifier, >>>> and an internal voltage reference. >>>> >>>> Note: While this chip shares similarities with the ADS112C14 (currently >>>> being upstreamed by David Lechner), the register maps and feature sets >>>> are sufficiently different to warrant a separate driver. However, the >>>> DT bindings and channel parsing logic have been aligned with the >>>> ADS112C14 conventions. >>>> >>>> This initial submission provides a minimal feature set (single-shot >>>> conversions and basic DRDY interrupt) covering current use cases. >>>> >>>> Signed-off-by: Kyle Hsieh <[email protected]> >>>> --- >>>> Changes in v3: >>>> - dt-bindings: iio: adc: ti,ads112c04: >>>> - Resolved dt_binding_check errors by removing redundant $ref for >>>> standard unit suffixes and fixing YAML array syntax. >>> Yet you still decided NOT TO TEST it before sending. >> >> Although after further looking this could be using properties added in >> iio tree, thus bot's report about failure. >> >> Well, if that is the case, that's unfortunate because if previous >> versions were not tested by you, this one cannot be tested by the bot, >> thus I look at this one as also untested. >> >> Best regards, >> Krzysztof > Hi Krzysztof, > > Thank you for the review and for following up in your second email. > I would like to clarify that I did indeed test v3 locally with `make > dt_binding_check` > before submitting, and it passed without any warnings on my end. > > As you accurately pointed out in your follow-up, the CI bot failure > appears to be > a cross-tree dependency issue. I apologize for not explicitly noting > this IIO tree > dependency in the cover letter to prevent the bot's confusion. > > I have also just updated my local `dtschema` tool directly from the > devicetree-org > GitHub master branch, and running `make dt_binding_check` on my tree still > completes silently with zero errors. > > Best regards, > Kyle Hsieh I already replied to the bot message before I saw this thread. The problem is the base-commit: in the cover letter. I'm guessing that you did `b4 prep --edit-deps` at some point and pointed it to something other than the actual tree you are working from. That would explain why the test passes locally but not with the bot.