[PATCH 06/12] iio: pressure: rohm-bm1390: Return error when read fails
Matti Vaittinen <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <ba361c8c8405d5e4f9d94fe0ec34b6c316593472.1786347811.git.mazziesaccount@gmail.com> |
From: Matti Vaittinen <[email protected]> The data reading function ignores the cached error value, and unconditionally returns 0. Return cached 'ret' -value after stopping the measurement so user knows if read failed and data is garbage. Signed-off-by: Matti Vaittinen <[email protected]> Fixes: 534674463a59 ("iio: bm1390: simplify using guard(mutex)") --- drivers/iio/pressure/rohm-bm1390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/pressure/rohm-bm1390.c b/drivers/iio/pressure/rohm-bm1390.c index b3be9de03678..d00d7ed54cb1 100644 --- a/drivers/iio/pressure/rohm-bm1390.c +++ b/drivers/iio/pressure/rohm-bm1390.c @@ -289,7 +289,7 @@ static int bm1390_read_data(struct bm1390_data *data, if (warn) dev_warn(data->dev, "Failed to stop measurement (%d)\n", warn); - return 0; + return ret; } static int bm1390_read_raw(struct iio_dev *idev, -- 2.55.0
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmp5g04ACgkQeFA3/03a ocWoaQf/fYgd7oXgOisk8Ykc/Qx6QTYiXoH5T8Vz9986RJOct8H/aJlTQdeh2GUA M7x9TrIQxAjyNwIp6ecO1Z2nNiWHbBx1C0yxxet+sQXqi4m2ACdW6vMQIf9SlZ91 5Abe7CgXKoLNm5c4+FjYsuKR+x45ErzvTUICHFaXghw5NKMumPozHyOdF+Ll9ioc ZMsDoAxTZFArIyQEBpCCL6ZswA8nIBnxvtqmoQQjJ3LEzsftYW+iblDd+G3KpVDP v9egcu6OY92M3n4gS7b55OATWieiN1l+AE++mEy4ZqoyvtrR6Me/cGlichnYSxPD M5XwDpf9Nhhbc6Qxzdg4LIsfjrfhYw== =2uDx -----END PGP SIGNATURE-----