Re: [PATCH v3 1/3] iio: adc: ti-ads112c14: add DRDY interrupt support
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Mon, Aug 10, 2026 at 10:59:20AM -0500, David Lechner wrote:
> On 8/10/26 3:50 AM, Andy Shevchenko wrote:
> > On Fri, Aug 07, 2026 at 04:19:46PM -0500, David Lechner (TI) wrote:
...
> >> + if (device_property_present(dev, "interrupts")) {
> >
> > Unfortunately this is no-go for ACPI-enabled systems.
> > On ACPI we expect to have 'interrupt-names' but 'interrupts' is OF-only.
>
> So device_property_present(dev, "interrupt-names") is OK?
As long as we use _irq_get_byname(), yes. Because the below call relies on that
property to be present in any supported FW description.
> >> + data->drdy_irq = fwnode_irq_get_byname(dev_fwnode(dev), "drdy");
OTOH, you may also introduce _optional() variant for this to avoid layering
violation (why should driver know about that property at all?). But I haven't
checked how many existing users (if any) we have. If none, perhaps also a
TODO/FIXME/et cetera here to point out on this.
--
With Best Regards,
Andy Shevchenko