Re: [PATCH v5 2/4] iio: light: add support for veml6031x00 ALS series

On Tue, Aug 11, 2026 at 01:06:42AM +0200, Javier Carrasco wrote:
> On Mon Aug 10, 2026 at 3:38 PM CEST, Andy Shevchenko wrote:
> > On Fri, Aug 07, 2026 at 03:51:53PM +0200, Javier Carrasco wrote:

...

> > + array_size.h // ARRAY_SIZE()
> >
> >> +#include <linux/bitfield.h>
> >
> > Is this in use?
> 
> This one is in use for FIELD_PREP()

Ah, I missed that.

> > + bits.h // BIT()
> >
> >> +#include <linux/cleanup.h>
> >> +#include <linux/delay.h>
> >
> >> +#include <linux/device.h>
> >
> > Oh, the whole headers hell is loaded just due to dev_get_drvdata() it seems...
> 
> I will rely on <linux/i2c.h> instead, which is also what I am going to do
> to get rid of <linux/mod_devicetable.h> as Uwe suggested.

Sure, but device.h is still required as you use it.

> >> +#include <linux/err.h>
> >> +#include <linux/i2c.h>
> >> +#include <linux/limits.h>
> >
> > I missed probably it, but is it used?
> 
> This one is used for U16_MAX.

Good!

> >> +#include <linux/module.h>
> >> +#include <linux/mod_devicetable.h>
> >> +#include <linux/mutex.h>
> >
> >> +#include <linux/pm.h>
> 
> The rest of your comments need no reply from my side.

-- 
With Best Regards,
Andy Shevchenko